Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] fix standalone mode that hides the navbar #3284

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

mistercrunch
Copy link
Member

fixes #2167

@coveralls
Copy link

coveralls commented Aug 13, 2017

Coverage Status

Coverage increased (+0.005%) to 69.419% when pulling 5f06638 on mistercrunch:dash_standalone into c9c6bca on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 69.419% when pulling 5f06638 on mistercrunch:dash_standalone into c9c6bca on apache:master.

@graceguo-supercat
Copy link

LGTM!

@mistercrunch mistercrunch merged commit 9a4e4d0 into apache:master Aug 14, 2017
@mistercrunch mistercrunch deleted the dash_standalone branch August 14, 2017 19:24
@h3
Copy link

h3 commented Nov 8, 2017

I would like to add a notitle option.

I'm currently integrating standalone dashboards into a multi-language app using iframes and it's quite bothering to have the untranslated title in the dashboard.

I don't mind implementing it and doing a pull request, but I don't wan't to waste my time neither..

Please let me know if such feature would have chances to be accepted.

Thanks

@praneetchandra
Copy link

I would like to add a notitle option.

I'm currently integrating standalone dashboards into a multi-language app using iframes and it's quite bothering to have the untranslated title in the dashboard.

I don't mind implementing it and doing a pull request, but I don't wan't to waste my time neither..

Please let me know if such feature would have chances to be accepted.

Thanks

Did we implement notitle mode ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full screen support for dashboard
5 participants