fix(helm-chart): Fix broken PodDisruptionBudget due to introduction of extraLabels.

[theoriginalgri]

SUMMARY

#30710 introduced extraLabels but broke the PodDisruptionBudgets due to pdb configs using "with" statements.

This is not catched by the linting since since checks are only performed with default values and PDBs are not enabled by default.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

$ helm lint ./helm/superset --set "supersetNode.podDisruptionBudget.enabled=true"
engine.go:227: [INFO] Fail: Only one of minAvailable or maxUnavailable should be set
==> Linting ./helm/superset
[ERROR] templates/: template: superset/templates/pdb.yaml:34:18: executing "superset/templates/pdb.yaml" at <.Values.extraLabels>: nil pointer evaluating interface {}.extraLabels

Error: 1 chart(s) linted, 1 chart(s) failed

After:

$ helm lint ./helm/superset --set "supersetNode.podDisruptionBudget.enabled=true"
engine.go:227: [INFO] Fail: Only one of minAvailable or maxUnavailable should be set
==> Linting ./helm/superset

1 chart(s) linted, 0 chart(s) failed

TESTING INSTRUCTIONS

helm lint ./helm/superset --set "supersetNode.podDisruptionBudget.enabled=true"

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[dpgaspar]

Looks good, thank you for the fix. Please bump the chart version

[villebro]

LGTM, thanks for the fix