-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Unable to parse escaped tables #30560
fix: Unable to parse escaped tables #30560
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #30560 +/- ##
===========================================
+ Coverage 60.48% 83.92% +23.43%
===========================================
Files 1931 533 -1398
Lines 76236 38544 -37692
Branches 8568 0 -8568
===========================================
- Hits 46114 32349 -13765
+ Misses 28017 6195 -21822
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
(cherry picked from commit fc857d9)
SUMMARY
#26476 introduced a
SQLGLOT_DIALECTS
mapping to be used when parsing SQL queries with SQLGlot. For companies that have custom database engines, with a name not present in the mapping, the default SQLGlot dialect would be used and could generate problems such as #30551. This PR adds a new configuration to allow extending registered SQLGlot dialects.Fixes #30551
TESTING INSTRUCTIONS
Check the original issue for instructions.
ADDITIONAL INFORMATION