chore: add logging for dashboards/get warnings #30365
Merged
+42
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We're currently not logging flask warnings to the logger as part of the "catch all" @safe or @handle_api_exception decorators. I think @handle_api_exception does a more thorough job of catching different errors and handling, logging, raising, etc. We're applying @handle_api_exception on most base restapi functions, but using @safe on the adhoc apis. Maybe we can look at combining these and only having one decorator. I also removed the exception handling in the api because they will be caught and handled in the decorator.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION