fix(user-dao): return user model instances

[villebro]

SUMMARY

#27849 introduced a DAO for the User model which didn't return instances of the security_manager.user_model. This fixes that issue, adds a unit test and also refactors the existing tests so that they no longer use mocks.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (76d897e) to head (6e405f2).
Report is 1094 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #30020       +/-   ##
===========================================
+ Coverage   60.48%   83.68%   +23.19%     
===========================================
  Files        1931      528     -1403     
  Lines       76236    38206    -38030     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31974    -14140     
+ Misses      28017     6232    -21785     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.92% <50.00%> (-0.25%)	⬇️
javascript	?
mysql	76.77% <100.00%> (?)
postgres	76.84% <100.00%> (?)
presto	53.48% <50.00%> (-0.32%)	⬇️
python	83.68% <100.00%> (+20.20%)	⬆️
sqlite	76.31% <100.00%> (?)
unit	60.28% <100.00%> (+2.66%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[villebro]

@michael-s-molina @sadpandajoe @rusackas we discussed this last Friday - can you take a look?

[mistercrunch]

LGTM