Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(capitalization): Capitalizing a button. #29867

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Aug 5, 2024

SUMMARY

Capitalizing the + Alert and + Report buttons.

Before:

image image

After:

image image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Aug 5, 2024
@mistercrunch
Copy link
Member

/testenv up

@mistercrunch
Copy link
Member

@yousoph asked for an env to test the capitalization

@kasiazjc
Copy link
Contributor

kasiazjc commented Aug 6, 2024

@rusackas I think @mistercrunch's test env command didn't work, can you try to do it? 🙏🏻

@rusackas rusackas merged commit 052b38b into master Aug 6, 2024
36 of 37 checks passed
@rusackas rusackas deleted the capitalization-fix branch August 6, 2024 16:29
@rusackas
Copy link
Member Author

rusackas commented Aug 6, 2024

Hah, I merged it too quickly, sorry... not sure why ephemerals aren't working. I did test it though, as seen in the screenshots.

There is one remaining inconsistency, but it seemed relatively minor. It asks in one modal "Delete Alert?" or "Delete Report?" now. I can just make it so that these strings aren't reused variables, and just put them in the correct capitalization in the places they go.

@kasiazjc
Copy link
Contributor

kasiazjc commented Aug 8, 2024

Hah, I merged it too quickly, sorry... not sure why ephemerals aren't working. I did test it though, as seen in the screenshots.

There is one remaining inconsistency, but it seemed relatively minor. It asks in one modal "Delete Alert?" or "Delete Report?" now. I can just make it so that these strings aren't reused variables, and just put them in the correct capitalization in the places they go.

Ha, it's on you now @rusackas 🤠

@rusackas
Copy link
Member Author

rusackas commented Aug 8, 2024

Maybe we're OK, depending on how our capitalization lawyers interpret this:

Where a product page is titled “Settings”, you refer to this in writing as follows: “Edit your personal information on the Settings page”.

@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 13, 2024
sadpandajoe pushed a commit that referenced this pull request Nov 13, 2024
@mistercrunch mistercrunch added 🍒 4.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 27, 2024
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants