Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): Add configs and formatting to discrete comparison columns #29553

Merged

Conversation

rtexelm
Copy link
Member

@rtexelm rtexelm commented Jul 10, 2024

SUMMARY

Allow the user to customize the comparison columns individually instead of being dictated by the parent metrics' configurations and formatting.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

B:

old-column-config.mov

A:

new-column-config.mov

TESTING INSTRUCTIONS

  • Create a table chart using a dataset that is viable for time comparison, i.e. has a temporal column
  • Add time comparison settings
  • In the 'customize' tab of the explorer, customize the comparison columns configuration

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@yousoph
Copy link
Member

yousoph commented Jul 10, 2024

/testenv up FLAG_CHART_PLUGINS_EXPERIMENTAL=True

Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.87.123.148:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rtexelm rtexelm force-pushed the gsg-table-format-columns-individually/sc-80918 branch from 6a76dc9 to 2daf04e Compare July 11, 2024 16:09
@rtexelm rtexelm marked this pull request as ready for review July 11, 2024 16:30
@dosubot dosubot bot added change:frontend Requires changing the frontend explore Namespace | Anything related to Explore explore:design Related to the Explore UI/UX labels Jul 11, 2024
@yousoph
Copy link
Member

yousoph commented Jul 11, 2024

/testenv up FLAG_CHART_PLUGINS_EXPERIMENTAL=True

Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://34.221.74.42:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

if (timeComparisonStatus) {
/**
* Replace numeric columns with sets of comparison columns.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the comments!

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rtexelm rtexelm merged commit dac69e2 into apache:master Jul 25, 2024
34 checks passed
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend explore:design Related to the Explore UI/UX explore Namespace | Anything related to Explore plugins size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants