Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename Totals to Summary in table chart #29360

Merged
merged 1 commit into from
Jun 25, 2024
Merged

chore: Rename Totals to Summary in table chart #29360

merged 1 commit into from
Jun 25, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR implements the results of the #29297 discussion.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-06-25 at 08 54 30

TESTING INSTRUCTIONS

Check the new nomenclature.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts:table Related to the Table chart label Jun 25, 2024
@michael-s-molina michael-s-molina merged commit 213fd69 into apache:master Jun 25, 2024
34 of 36 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 25, 2024
michael-s-molina added a commit that referenced this pull request Jun 26, 2024
@michael-s-molina
chore: Rename Totals to Summary in table chart (#29360)
fc97a81
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@michael-s-molina @eschutho
chore: Rename Totals to Summary in table chart (#29360)
fdabe2e
irublev pushed a commit to HighviewPower/superset that referenced this pull request Oct 29, 2024
@michael-s-molina
chore: Rename Totals to Summary in table chart (apache#29360)
68cc836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

@rusackas rusackas rusackas approved these changes

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/M v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch viz:charts:table Related to the Table chart 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-s-molina @rusackas @john-bodley @mistercrunch