fix(sqllab): invalid empty state on switch tab #29278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
approved these changes
Jun 18, 2024
michael-s-molina
added
the
v4.0
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 26, 2024
mistercrunch
added
🍒 4.0.2
🏷️ bot
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
irublev
pushed a commit
to HighviewPower/superset
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The current DB selection empty state screen is modified through the setEmptyState function. As a result, when tabs switch and share the same DB selection ID, the setEmptyState call is ignored, leading to a bug where the empty state is displayed even when a DB is selected.
This commit unifies the state management by using useMemo to ensure that the showEmpty value is always set when there is a currently selected DB.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--empty-on-switch-tab.mov
After:
after--empty-on-switch-tab.mov
TESTING INSTRUCTIONS
Open multiple tabs that selects the same db and then switch tabs each others
ADDITIONAL INFORMATION