fix: Custom SQL filter control #29260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
explore:filter
| @@ -95,11 +90,6 @@ export default class AdhocFilterEditPopoverSqlTabContent extends Component { | |||
| render() { | |||
| const { adhocFilter, height, options } = this.props; | |||
|
|
|||
| const clauseSelectProps = { | |||
There was a problem hiding this comment.
Moved to the component declaration.
justinpark
approved these changes
Jun 14, 2024
john-bodley
added
v4.0
michael-s-molina
added a commit
that referenced
this pull request
Jun 14, 2024
michael-s-molina
added a commit
that referenced
this pull request
Jun 14, 2024
john-bodley
removed
the
review:checkpoint
mistercrunch
added
🍒 4.0.2
🏷️ bot
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
3 tasks
irublev
pushed a commit
to HighviewPower/superset
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a number of problems with the Custom SQL filter control:
Whereclause was actually being applied asHAVING. This bug was introduced in chore: make TS enums strictly PascalCase #26875.This PR also reimplements the tests using RTL and creates a helper function to interact with the
Selectcomponent in tests.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-06-14.at.13.13.32.mov
Screen.Recording.2024-06-14.at.09.41.17.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION