Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Set priorityClassName to pods (superset, celeryBeat, celeryBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) #29091

Merged
merged 8 commits into from
Jun 6, 2024

Conversation

sabyrzhan
Copy link
Contributor

SUMMARY

Add ability to assign custom priorityClassName to pods. Each workload (superset, celeryBeat, celeryBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) has ability to assign custom priorityClassName

TESTING INSTRUCTIONS

Specify custom priorityClassName to one of the deployments (superset, celeryBeat, celeryBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) to assign to its pods

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the deploy:helm label Jun 5, 2024
@sabyrzhan sabyrzhan changed the title fix(helm): Add priorityClassName to pods (superset, celeryBeat, celeryBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) fix(helm): Set priorityClassName to pods (superset, celeryBeat, celeryBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) Jun 5, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@craig-rueda
Copy link
Member

Can you please bump the chart version and re-build the chart README?

@sabyrzhan
Copy link
Contributor Author

@craig-rueda Yes, I can. But isnt it done automatically after the merge? Or should I trigger manually a workflow? Could you just elaborate a little about the process please?

@sabyrzhan
Copy link
Contributor Author

Ok, I see it needs to be released locally if I am not wrong, and send as a separate PR like this, is that right?
#27946

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I've also needed this, so I assume this is useful to the general public, too). Not sure what the unrelated lint issue is, will try to repro locally.

@sabyrzhan
Copy link
Contributor Author

@villebro Thank you for review. I wrote yesterday in slack channel. Maybe you missed it.
The related MR that broke it is this: #28762 from @hanslemm.
Seems like linting skipped on it: https://github.com/apache/superset/actions/runs/9381289976

@villebro
Copy link
Member

villebro commented Jun 6, 2024

@villebro Thank you for review. I wrote yesterday in slack channel. Maybe you missed it. The related MR that broke it is this: #28762 from @hanslemm. Seems like linting skipped on it: https://github.com/apache/superset/actions/runs/9381289976

@sabyrzhan oh, that skip on CI shouldn't have happened IMO (probably warrants looking into separately from this, though) 🙁 Do you think you'll be able to fix it as a bycatch here? I'm assuming it should be simple to fix. If not I can take a stab at it.

@sabyrzhan
Copy link
Contributor Author

@villebro sure, not a problem. Will start fixing right now and push it.

@villebro
Copy link
Member

villebro commented Jun 6, 2024

Thanks @sabyrzhan !

@sabyrzhan
Copy link
Contributor Author

@villebro Pushed the fix.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restamping - big thanks for fixing this unrelated error!

@villebro villebro merged commit f2e020e into apache:master Jun 6, 2024
34 checks passed
eschutho pushed a commit that referenced this pull request Jul 24, 2024
…yBeatFlower, celeryBeatWorker, celeryBeatWebsocket, jobs) (#29091)
@sabyrzhan
Copy link
Contributor Author

@villebro Any estimates when the next release of the helm chart is going to be? I see the last one was on May.

@villebro
Copy link
Member

villebro commented Aug 6, 2024

@sabyrzhan the helm chart should be automatically released by CI. Let me take a look to see why this is not the case..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants