fix(embedded): add missing GUEST_TOKEN_HEADER_NAME to bootstrap data

[hexcafe]

SUMMARY

There's a discrepancy between our backend configuration and frontend implementation for GUEST_TOKEN_HEADER_NAME.

We allow customization of GUEST_TOKEN_HEADER_NAME in the backend configuration.
However, this configuration is not being passed to the frontend.

As a result, the ability to customize the header name in the frontend is currently not functional.

superset/superset-frontend/src/embedded/index.tsx

Lines 153 to 159 in bc9eab9

	function setupGuestClient(guestToken: string) {
	setupClient({
	guestToken,
	guestTokenHeaderName: bootstrapData.config?.GUEST_TOKEN_HEADER_NAME,
	unauthorizedHandler: guestUnauthorizedHandler,
	});
	}

superset/superset/embedded/view.py

Lines 79 to 85 in bc9eab9

	bootstrap_data = {
	"common": common_bootstrap_payload(),
	"embedded": {
	"dashboard_id": embedded.dashboard_id,
	},
	}

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (76d897e) to head (3414f78).
Report is 272 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #28932       +/-   ##
===========================================
+ Coverage   60.48%   83.66%   +23.17%     
===========================================
  Files        1931      518     -1413     
  Lines       76236    37463    -38773     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31344    -14770     
+ Misses      28017     6119    -21898     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.94% <100.00%> (-0.23%)	⬇️
javascript	?
mysql	77.23% <100.00%> (?)
postgres	77.34% <100.00%> (?)
presto	53.54% <100.00%> (-0.27%)	⬇️
python	83.66% <100.00%> (+20.17%)	⬆️
sqlite	76.79% <100.00%> (?)
unit	59.02% <100.00%> (+1.39%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[john-bodley]

Thanks for the fix @hexcafe. Per here it seems like the frontend is expecting said header.

[john-bodley]

LGTM. @hexcafe you'll have to run tox -e pre-commit locally in order to fix the formatting.

[suddjian]

Sorry for this oversight, thanks for the fix :)

[hexcafe]

@john-bodley @suddjian Thank you for merging this PR. Could we backport this patch to version 4.0? It could be beneficial for future users of version 4.0 who need to embed the dashboard.