Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sqllab): Add logging for actions #28876

Merged
merged 3 commits into from
Jun 14, 2024
Merged

chore(sqllab): Add logging for actions #28876

merged 3 commits into from
Jun 14, 2024

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Jun 3, 2024 •
edited
Loading

SUMMARY

This commit adds loggings for SQL Lab page actions. It also includes the shortcut: boolean payload for actions that are possible via keyboard shortcuts.

_DEV__Superset

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

event name screenshot
LOG_ACTIONS_SQLLAB_RUN_QUERY Screenshot 2024-06-03 at 3 26 54 PM
LOG_ACTIONS_SQLLAB_STOP_QUERY Screenshot 2024-06-03 at 4 52 50 PM
LOG_ACTIONS_SQLLAB_COPY_LINK Screenshot 2024-06-03 at 3 26 43 PM
LOG_ACTIONS_SQLLAB_SAVE_QUERY Screenshot 2024-06-03 at 3 27 12 PM
LOG_ACTIONS_SQLLAB_CREATE_CHART Screenshot 2024-06-03 at 4 07 54 PM
LOG_ACTIONS_SQLLAB_DOWNLOAD_CSV Screenshot 2024-06-03 at 4 11 45 PM
LOG_ACTIONS_SQLLAB_FORMAT_SQL Screenshot 2024-06-03 at 4 47 17 PM
LOG_ACTIONS_SQLLAB_SAVE_QUERY Screenshot 2024-06-03 at 4 48 56 PM
LOG_ACTIONS_SQLLAB_COPY_RESULT_TO_CLIPBOARD Screenshot 2024-06-03 at 5 01 11 PM

TESTING INSTRUCTIONS

specs and logging screenshot attached

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added logging Creates a UI or API endpoint that could benefit from logging. sqllab Namespace | Anything related to the SQL Lab labels Jun 3, 2024
mistercrunch
mistercrunch approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the more logging the better

@justinpark justinpark merged commit 05829cb into apache:master Jun 14, 2024
34 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 14, 2024
michael-s-molina pushed a commit that referenced this pull request Jun 14, 2024
@justinpark @michael-s-molina
chore(sqllab): Add logging for actions (#28876)
21cb4a9 
(cherry picked from commit 05829cb)
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@justinpark @eschutho
chore(sqllab): Add logging for actions (#28876)
5329ca7
irublev pushed a commit to HighviewPower/superset that referenced this pull request Oct 29, 2024
@justinpark @michael-s-molina
chore(sqllab): Add logging for actions (apache#28876)
9f8d905 
(cherry picked from commit 3d785e8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

@rusackas rusackas Awaiting requested review from rusackas

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@eschutho eschutho Awaiting requested review from eschutho

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels logging Creates a UI or API endpoint that could benefit from logging. size/L sqllab Namespace | Anything related to the SQL Lab v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinpark @mistercrunch @michael-s-molina