Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Change class name on last Droppable in a column #28395

Merged
merged 2 commits into from
May 10, 2024
Merged

fix(dashboard): Change class name on last Droppable in a column #28395

merged 2 commits into from
May 10, 2024

Conversation

rtexelm
Copy link
Member

@rtexelm rtexelm commented May 9, 2024 •
edited
Loading

SUMMARY

This is meant to allow resizing of each item in a column. No longer will the last child be bereft of resizing capabilities.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

B:
no-resize-column-ezgif com-optimize
A:
ezgif com-optimize

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Unable to resize the cards inside a column #28209
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rtexelm rtexelm changed the title fix (dashboard): Add resizable wrapper to each column item fix(dashboard): Add resizable wrapper to each column item May 9, 2024
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label May 9, 2024
@pull-request-size pull-request-size bot added size/XS and removed size/M labels May 9, 2024
@rtexelm rtexelm marked this pull request as ready for review May 9, 2024 22:31
@rtexelm rtexelm changed the title fix(dashboard): Add resizable wrapper to each column item fix(dashboard): Change class name on last Droppable in a column May 9, 2024
eschutho
eschutho approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eschutho eschutho merged commit b015764 into apache:master May 10, 2024
54 of 59 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label May 13, 2024
michael-s-molina pushed a commit that referenced this pull request May 13, 2024
@rtexelm @michael-s-molina
fix(dashboard): Change class name on last Droppable in a column (#28395)
4423961 
(cherry picked from commit b015764)
aehanno pushed a commit to kosmos-education/superset that referenced this pull request May 13, 2024
@rtexelm @aehanno
fix(dashboard): Change class name on last Droppable in a column (apac…
bc772ba 
…he#28395)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@rtexelm @jzhao62
fix(dashboard): Change class name on last Droppable in a column (apac…
134b0ad 
…he#28395)
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label May 23, 2024
@justinpark justinpark mentioned this pull request May 29, 2024
Merged
9 tasks
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@rtexelm @EnxDev
fix(dashboard): Change class name on last Droppable in a column (apac…
a3f50ee 
…he#28395)
eschutho pushed a commit that referenced this pull request Jun 5, 2024
@rtexelm @sadpandajoe
fix(dashboard): Change class name on last Droppable in a column (#28395)
a18dfb8 
(cherry picked from commit b015764)
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
irublev pushed a commit to HighviewPower/superset that referenced this pull request Oct 29, 2024
@rtexelm @michael-s-molina
fix(dashboard): Change class name on last Droppable in a column (apac…
875573a 
…he#28395)

(cherry picked from commit 0b9c451)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@rtexelm
fix(dashboard): Change class name on last Droppable in a column (apac…
f43ec36 
…he#28395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to resize the cards inside a column
5 participants
@rtexelm @eschutho @mistercrunch @john-bodley @michael-s-molina