fix: don't strip SQL comments in Explore #28363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up in the footsteps of #27725 as comments can be used as a way to pass the database engine hints, or for logging purposes.
mistercrunch
changed the title
john-bodley
approved these changes
May 7, 2024
There was a problem hiding this comment.
@mistercrunch I agree with this approach. I think historically we did this to aid with traversing the sqlparse AST, but as we migrate to SQLGlot I suspect this requirement can likely be relaxed.
|
Found some comments in the code around stripping comments prior to checkit |
michael-s-molina
added
the
v4.0
michael-s-molina
pushed a commit
that referenced
this pull request
May 8, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
May 8, 2024
imancrsrk
pushed a commit
to imancrsrk/superset
that referenced
this pull request
May 10, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
michael-s-molina
added a commit
to michael-s-molina/superset
that referenced
this pull request
May 17, 2024
This reverts commit c618767.
9 tasks
michael-s-molina
added a commit
that referenced
this pull request
May 17, 2024
michael-s-molina
added a commit
that referenced
this pull request
May 17, 2024
michael-s-molina
added a commit
that referenced
this pull request
May 17, 2024
mistercrunch
added a commit
that referenced
this pull request
May 29, 2024
Here I'm trying to recreate the issue that led to revert #28363 in #28567, likely some sort of trailing comment of some kind. This is DRAFT for now until I can reproduce the issue, write a covering test for it, and address it. First attempt at creating a problematic virtual dataset was the following ->
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
mistercrunch
added a commit
that referenced
this pull request
Jun 3, 2024
Here I'm trying to recreate the issue that led to revert #28363 in #28567, likely some sort of trailing comment of some kind. This is DRAFT for now until I can reproduce the issue, write a covering test for it, and address it. First attempt at creating a problematic virtual dataset was the following ->
mistercrunch
added a commit
that referenced
this pull request
Jun 7, 2024
Here I'm trying to recreate the issue that led to revert #28363 in #28567, likely some sort of trailing comment of some kind. This is DRAFT for now until I can reproduce the issue, write a covering test for it, and address it. First attempt at creating a problematic virtual dataset was the following ->
9 tasks
mistercrunch
added a commit
that referenced
this pull request
Jun 18, 2024
Here I'm trying to recreate the issue that led to revert #28363 in #28567, likely some sort of trailing comment of some kind. This is DRAFT for now until I can reproduce the issue, write a covering test for it, and address it. First attempt at creating a problematic virtual dataset was the following ->
3 tasks
mistercrunch
added
🍒 4.0.2
🏷️ bot
irublev
pushed a commit
to HighviewPower/superset
that referenced
this pull request
Oct 29, 2024
irublev
pushed a commit
to HighviewPower/superset
that referenced
this pull request
Oct 29, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up in the footsteps of #27725 as comments can be used as a way to pass the database engine hints, or for logging purposes.