Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small tweaks for Line and Area chart migrations (ECharts) #28334

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes some issues found while testing Line and Area chart migrations (ECharts) using Airbnb's production data:

TESTING INSTRUCTIONS

CI is sufficient as I'm already testing the migrations with a lot of data.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from a team as a code owner May 3, 2024 12:15
@github-actions github-actions bot added risk:db-migration PRs that require a DB migration plugins labels May 3, 2024
@dosubot dosubot bot added the viz:charts:echarts Related to Echarts label May 3, 2024
@michael-s-molina michael-s-molina removed the risk:db-migration PRs that require a DB migration label May 3, 2024
@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label May 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 70.04%. Comparing base (2e5f3ed) to head (a1a1ac9).
Report is 29 commits behind head on master.

Files Patch % Lines
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% 2 Missing ⚠️
...gin-chart-echarts/src/Timeseries/transformProps.ts 60.00% 1 Missing and 1 partial ⚠️
...perset/migrations/shared/migrate_viz/processors.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28334      +/-   ##
==========================================
+ Coverage   60.49%   70.04%   +9.54%     
==========================================
  Files        1931     1933       +2     
  Lines       76241    76500     +259     
  Branches     8566     8567       +1     
==========================================
+ Hits        46122    53583    +7461     
+ Misses      28015    20813    -7202     
  Partials     2104     2104              
Flag Coverage Δ
hive 49.21% <0.00%> (+0.04%) ⬆️
javascript 57.72% <42.85%> (+<0.01%) ⬆️
mysql 77.56% <0.00%> (?)
postgres 77.67% <0.00%> (?)
presto 53.83% <0.00%> (+0.03%) ⬆️
python 83.26% <66.66%> (+19.77%) ⬆️
sqlite 77.14% <0.00%> (?)
unit 57.72% <66.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -128,6 +128,10 @@ def _pre_action(self) -> None:
):
self.data["bottom_margin"] = 30

left_margin = self.data.get("left_margin")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just ensuring consistency with other EChart implementations?

@michael-s-molina michael-s-molina merged commit b4ab36a into apache:master May 7, 2024
28 checks passed
@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch and removed risk:db-migration PRs that require a DB migration labels May 8, 2024
michael-s-molina added a commit that referenced this pull request May 8, 2024
imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
irublev pushed a commit to HighviewPower/superset that referenced this pull request Oct 29, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch viz:charts:echarts Related to Echarts 🍒 4.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants