-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(translations): fix translations order #28031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b830408
to
106613c
Compare
@@ -765,8 +765,8 @@ def _extract_tables_from_sql(self) -> set[Table]: | |||
SupersetError( | |||
error_type=SupersetErrorType.QUERY_SECURITY_ACCESS_ERROR, | |||
message=__( | |||
f"You may have an error in your SQL statement. {message}" | |||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if @john-bodley knows a good way to lint against this. According to GPT, we can write a custom pylint checker, but it seems like that would be a first for this codebase. Something off the shelf to prevent this would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rusackas we have custom (WIP) Pylint checkers. I guess one would need to add one to check whether there's an f-string being used within a translation __(...)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, could you point me to where those live, @john-bodley, and I'll try to GPT us out of this issue?
Running CI 🤞 |
Thanks for taking a look everyone. I fixed the line endings of the .po and .pot files, which were failing the CI. |
Running Ci... then we'll merge it! |
SUMMARY
This PR does two things:
This PR does not include any changes to the translations themselves.
TESTING INSTRUCTIONS
When extracting the messages from using the documented pybabel commands, without any translation changes, the message.pot file should not change (except for the license information).
ADDITIONAL INFORMATION
Fixes #27894