Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce alert error to warning #27744

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: reduce alert error to warning #27744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/commands/report/alert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
logger.warning("A timeout occurred while executing the alert query: %s", ex)
raise AlertQueryTimeout() from ex
except Exception as ex:
logger.exception("An error occurred when running alert query")
logger.warning("An error occurred when running alert query")

Check warning on line 174 in superset/commands/report/alert.py

View check run for this annotation

Codecov / codecov/patch

superset/commands/report/alert.py#L174 

Added line #L174 was not covered by tests
# The exception message here can reveal to much information to malicious
# users, so we raise a generic message.
raise AlertQueryError(
Expand Down
Loading