feat(plugins): add color options for big number with time comparison #27524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27524 +/- ##
=======================================
Coverage 67.39% 67.39%
=======================================
Files 1909 1909
Lines 74741 74741
Branches 8327 8329 +2
=======================================
Hits 50369 50369
Misses 22322 22322
Partials 2050 2050
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ggam
reviewed
Mar 15, 2024
| visibility: ({ controls }) => | ||
| controls?.comparison_color_enabled?.value === true, | ||
| description: t( | ||
| ' Adds color to the chart symbols based on the positive or' + |
There was a problem hiding this comment.
Missing trailing space. Currently it's being rendered as positive ornegative
There was a problem hiding this comment.
nice catch, thank you!
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 18, 2024
…pache#27524) (cherry picked from commit ae29427)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 19, 2024
…pache#27524) (cherry picked from commit ae29427)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 22, 2024
…pache#27524) (cherry picked from commit ae29427)
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 26, 2024
…pache#27524) (cherry picked from commit ae29427)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 26, 2024
…pache#27524) (cherry picked from commit ae29427)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 28, 2024
…pache#27524) (cherry picked from commit ae29427)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 1, 2024
…pache#27524) (cherry picked from commit ae29427)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 2, 2024
…pache#27524) (cherry picked from commit ae29427)
EandrewJones
pushed a commit
to UMD-ARLIS/superset
that referenced
this pull request
Apr 5, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request adds a feature to the Big number with time comparison chart, allowing users to color-code positive and negative changes. It introduces a dropdown menu for selecting between two color schemes: the default "Green for increase, Red for decrease" or "Red for increase, Green for decrease." Users can switch between these options, and the chart will update automatically to reflect the change.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION