Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql lab] fix responsivity of grid #2742

Merged
merged 2 commits into from
May 11, 2017
Merged

[sql lab] fix responsivity of grid #2742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5898e6c
[sql lab] fix responsivity of grid
mistercrunch May 10, 2017
12c7891
Lint
mistercrunch May 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,12 @@ class SqlEditor extends React.PureComponent {
<Collapse
in={!this.props.hideLeftBar}
>
<Col md={3}>
<Col
xs={6}
sm={5}
md={4}
lg={3}
>
<SqlEditorLeftBar
height={this.sqlEditorHeight()}
queryEditor={this.props.queryEditor}
Expand All @@ -202,7 +207,12 @@ class SqlEditor extends React.PureComponent {
/>
</Col>
</Collapse>
<Col md={this.props.hideLeftBar ? 12 : 9}>
<Col
xs={this.props.hideLeftBar ? 12 : 6}
sm={this.props.hideLeftBar ? 12 : 7}
md={this.props.hideLeftBar ? 12 : 8}
lg={this.props.hideLeftBar ? 12 : 9}
>
<AceEditorWrapper
actions={this.props.actions}
onBlur={this.setQueryEditorSql.bind(this)}
Expand Down