Detecting loops in Sankeys #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| recs = df.to_dict(orient='records') | ||
| seen = set() | ||
| hierarchy = {row['source']: row['target'] for row in recs} | ||
| def find_loop(source, target): |
There was a problem hiding this comment.
might just be me but comments might make this a little more readable. not huge deal.
|
super nice add / nice debugging! LGTM overall, though I can't tell if the failed tests were intentional or not. Detecting sankey loops seems like a good opportunity for a test(s). |
|
Yeah I'm confused, apparently there's a loop in the example, but how does it still work then! I'll have to dig deeper |
|
see the slack channel for another example of a broken sankey, cc-ed you. |
mistercrunch
force-pushed
the
sankey_loop
branch
from
d983413
to
dc48468
Compare
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@williaster