Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlparse): improve table parsing #26476

Merged
merged 4 commits into from
Jan 22, 2024

Cleanup code

f512f33
Select commit
Loading
Failed to load commit list.
Merged

fix(sqlparse): improve table parsing #26476

Cleanup code
f512f33
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 22, 2024 in 1s

85.71% of diff hit (target 69.16%)

View this Pull Request on Codecov

85.71% of diff hit (target 69.16%)

Annotations

Check warning on line 996 in superset/db_engine_specs/base.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/db_engine_specs/base.py#L996

Added line #L996 was not covered by tests

Check warning on line 1493 in superset/db_engine_specs/base.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/db_engine_specs/base.py#L1493

Added line #L1493 was not covered by tests

Check warning on line 1528 in superset/db_engine_specs/base.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/db_engine_specs/base.py#L1528

Added line #L1528 was not covered by tests

Check warning on line 438 in superset/db_engine_specs/bigquery.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/db_engine_specs/bigquery.py#L438

Added line #L438 was not covered by tests

Check warning on line 1097 in superset/models/helpers.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/models/helpers.py#L1097

Added line #L1097 was not covered by tests

Check warning on line 425 in superset/sql_lab.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/sql_lab.py#L424-L425

Added lines #L424 - L425 were not covered by tests

Check warning on line 63 in superset/sql_parse.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/sql_parse.py#L63

Added line #L63 was not covered by tests

Check warning on line 324 in superset/sql_parse.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/sql_parse.py#L324

Added line #L324 was not covered by tests