Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlparse): improve table parsing #26476

Merged
merged 4 commits into from
Jan 22, 2024

Pass engine to ParsedQuery

b984b9c
Select commit
Loading
Failed to load commit list.
Merged

fix(sqlparse): improve table parsing #26476

Pass engine to ParsedQuery
b984b9c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 19, 2024 in 1s

70.26% (+1.09%) compared to e36c014

View this Pull Request on Codecov

70.26% (+1.09%) compared to e36c014

Details

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (e36c014) 69.16% compared to head (b984b9c) 70.26%.
Report is 89 commits behind head on master.

Files Patch % Lines
superset/db_engine_specs/base.py 50.00% 3 Missing ⚠️
superset/sql_parse.py 93.02% 3 Missing ⚠️
superset/sql_lab.py 66.66% 2 Missing ⚠️
superset/db_engine_specs/bigquery.py 0.00% 1 Missing ⚠️
superset/models/helpers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26476      +/-   ##
==========================================
+ Coverage   69.16%   70.26%   +1.09%     
==========================================
  Files        1948     1949       +1     
  Lines       76062    80471    +4409     
  Branches     8493     8493              
==========================================
+ Hits        52609    56541    +3932     
- Misses      21273    21750     +477     
  Partials     2180     2180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.