Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(databend): databend time grain expression #26378

Merged

Conversation

hantmac
Copy link
Contributor

@hantmac hantmac commented Dec 29, 2023

SUMMARY

Fix the time_grain_expression in databend.

Fixes #26360

TESTING INSTRUCTIONS

Create databend database -> create dataset -> edit chart -> select timestamp field -> select Time Grain. There are time grain options to be selected.

ADDITIONAL INFORMATION

  • Has associated issue: [Databend datasource] Can't get TIME GRAIN when create chart on dataset #26360
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b6d433d) 69.17% compared to head (656afdf) 69.17%.
Report is 5 commits behind head on master.

Files Patch % Lines
superset/db_engine_specs/databend.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26378      +/-   ##
==========================================
- Coverage   69.17%   69.17%   -0.01%     
==========================================
  Files        1945     1945              
  Lines       75979    75982       +3     
  Branches     8476     8476              
==========================================
+ Hits        52562    52564       +2     
- Misses      21227    21228       +1     
  Partials     2190     2190              
Flag Coverage Δ
hive 53.68% <33.33%> (-0.01%) ⬇️
mysql 78.07% <33.33%> (-0.01%) ⬇️
postgres 78.17% <33.33%> (-0.01%) ⬇️
presto 53.63% <33.33%> (-0.01%) ⬇️
python 82.85% <66.66%> (-0.01%) ⬇️
sqlite 76.83% <33.33%> (-0.01%) ⬇️
unit 55.80% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina added the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label Dec 29, 2023
@michael-s-molina michael-s-molina merged commit 3a0391b into apache:master Dec 29, 2023
40 checks passed
michael-s-molina pushed a commit that referenced this pull request Jan 3, 2024
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Databend datasource] Can't get TIME GRAIN when create chart on dataset
3 participants