fix(chart): Set max row limit + removed the option to use an empty row limit value

[CorbinBullard]

SUMMARY

• Can no longer clear/remove the row limit
• New validator that checks if a value is larger than a given input
• Removed ValidateNonEmpty() validator that was causing charts before the update not to render

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:


After:

[john-bodley]

Thanks @CorbinBullard for the PR. Is this recreation of a previous PR? If so would you mind linking said PR in the PR description to help provide context/lineage.

[CorbinBullard]

Here is the original PR that was reverted #25579

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d37968) 69.18% compared to head (7edb455) 69.19%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26151      +/-   ##
==========================================
+ Coverage   69.18%   69.19%   +0.01%     
==========================================
  Files        1945     1946       +1     
  Lines       75970    75920      -50     
  Branches     8467     8469       +2     
==========================================
- Hits        52558    52533      -25     
+ Misses      21225    21200      -25     
  Partials     2187     2187              

Flag	Coverage Δ
javascript	56.53% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michael-s-molina]

The max value should come from SQL_MAX_ROW and not be a fixed 100,000.

[michael-s-molina]

LGTM

[Stefan781]

Using Superset 3.1, I am limited to 100 000 rows even if I set both SQL_MAX_ROW and ROW_LIMIT. Is that the expected behavior? How can I set a higher limit?
EDIT: Setting it to below 100 000 results in the same limit.

[Stefan781]

I debugged further. For that, I had to use an already existing chart that had a limit of more than 100 000 prior to the upgrade to 3.1.
Changing the SQL_MAX_ROW to 5000 results in a proper LIMIT 5000; in the query. Bringing it back up updates the value accordingly, up until the chart's original row limit. However, the check is still kept to 100 000 when creating the chart. This points to an issue with those changes. Could somebody confirm?