chore: Add entry point for SliceHeader frontend extension #25968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -239,6 +242,9 @@ const SliceHeader: FC<SliceHeaderProps> = ({ | |||
| <div className="header-controls"> | |||
| {!editMode && ( | |||
| <> | |||
| {SliceHeaderExtension && ( | |||
There was a problem hiding this comment.
Can we add a test for when the extension is provided?
eschutho
reviewed
Nov 13, 2023
| @@ -239,6 +242,9 @@ const SliceHeader: FC<SliceHeaderProps> = ({ | |||
| <div className="header-controls"> | |||
| {!editMode && ( | |||
| <> | |||
| {SliceHeaderExtension && ( | |||
| <SliceHeaderExtension slice={slice} dashboardId={dashboardId} /> | |||
There was a problem hiding this comment.
do we need the entire slice or just the id?
There was a problem hiding this comment.
You're right, if an extension needs entire slice, it can be pulled from redux store using just the id. Updated
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds
dashboard.slice.headerto frontend extensions registry for a SliceHeaderExtension componentBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
No changes expected
ADDITIONAL INFORMATION