-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(issue template): attempting to fix two entries/links #25881
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25881 +/- ##
==========================================
+ Coverage 69.00% 69.02% +0.01%
==========================================
Files 1938 1938
Lines 75829 75829
Branches 8427 8427
==========================================
+ Hits 52326 52340 +14
+ Misses 21334 21314 -20
- Partials 2169 2175 +6
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared one idea for URL formatting, LGTM though!
Co-authored-by: Sam Firke <[email protected]>
) Co-authored-by: Sam Firke <[email protected]>
) Co-authored-by: Sam Firke <[email protected]>
) Co-authored-by: Sam Firke <[email protected]>
) Co-authored-by: Sam Firke <[email protected]>
SUMMARY
Two things here:
The SIP button recently disappeared. I think it might be due to the bad markdown link OR the fact that we had a URL sitting there as a (non-working) markdown link. This adds parenthesis back to it, for good measure.
The Slack link wasn't working. I assume it's because the string contained a slash that was causing a parsing error. Hopefully this fixes it? ¯\_(ツ)_/¯
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION