Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(issue template): attempting to fix two entries/links #25881

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Nov 6, 2023

SUMMARY

Two things here:

  1. The SIP button recently disappeared. I think it might be due to the bad markdown link OR the fact that we had a URL sitting there as a (non-working) markdown link. This adds parenthesis back to it, for good measure.

  2. The Slack link wasn't working. I assume it's because the string contained a slash that was causing a parsing error. Hopefully this fixes it? ¯\_(ツ)_/¯

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #25881 (4677e05) into master (887be5d) will increase coverage by 0.01%.
Report is 23 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25881      +/-   ##
==========================================
+ Coverage   69.00%   69.02%   +0.01%     
==========================================
  Files        1938     1938              
  Lines       75829    75829              
  Branches     8427     8427              
==========================================
+ Hits        52326    52340      +14     
+ Misses      21334    21314      -20     
- Partials     2169     2175       +6     
Flag Coverage Δ
hive 53.66% <ø> (ø)
javascript 56.26% <ø> (+0.03%) ⬆️
mysql 78.25% <ø> (ø)
postgres 78.35% <ø> (ø)
presto 53.61% <ø> (ø)
python 82.78% <ø> (ø)
sqlite 77.00% <ø> (ø)
unit 55.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@rusackas rusackas changed the title chore(issue template) attempting to fix two entries chore(issue template): attempting to fix two entries/links Nov 6, 2023
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared one idea for URL formatting, LGTM though!

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@rusackas rusackas merged commit 84a894c into master Nov 9, 2023
51 checks passed
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke added a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch deleted the more-template-fixes branch March 26, 2024 18:06
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants