-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: handling "System limit for number of file watchers reached" error #25551
Conversation
Updated document for "System limit for number of file watchers reached" error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I can review from a language + formatting point of view, but I am unfamiliar with building the assets and would like someone to review this who can evaluate the code itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed it from an operating system perspective. Please make the suggested changes.
Thanks for review. I have updated the docs as per changes suggested. |
@mdeshmu could you please review. |
@sfirke please review |
@sfirke request you to review. |
CONTRIBUTING.md
Outdated
cat /proc/sys/fs/inotify/max_user_watches | ||
``` | ||
Edit the file /etc/sysctl.conf to increase this value. | ||
The value needs to be decided based on the system memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value needs to be decided based on the system memory. | |
The value needs to be decided based on the system memory [(see this StackOverflow answer for more context)](https://stackoverflow.com/questions/535768/what-is-a-reasonable-amount-of-inotify-watches-with-linux). |
CONTRIBUTING.md
Outdated
@@ -610,6 +610,32 @@ Then put this: | |||
export NODE_OPTIONS=--no-experimental-fetch | |||
``` | |||
|
|||
If Following type of error comes while running dev server(i.e using above commands): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Following type of error comes while running dev server(i.e using above commands): | |
If while using the above commands you encounter an error related to the limit of file watchers: |
CONTRIBUTING.md
Outdated
Error: ENOSPC: System limit for number of file watchers reached | ||
``` | ||
The error is thrown because the number of files monitored by the system has reached the limit. | ||
The error can be fixed by increasing the amount of inotify watchers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error can be fixed by increasing the amount of inotify watchers. | |
You can address this this error by increasing the number of inotify watchers. |
CONTRIBUTING.md
Outdated
The error is thrown because the number of files monitored by the system has reached the limit. | ||
The error can be fixed by increasing the amount of inotify watchers. | ||
|
||
Do the following to Modify the number of system monitoring files : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the following to Modify the number of system monitoring files : |
CONTRIBUTING.md
Outdated
Do the following to Modify the number of system monitoring files : | ||
|
||
|
||
The current value of max watches can be checked by below command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current value of max watches can be checked by below command. | |
The current value of max watches can be checked with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR sometimes says "watches" and sometimes "watchers" - is it correct that both terms get used in this context?
CONTRIBUTING.md
Outdated
```bash | ||
fs.inotify.max_user_watches=524288 | ||
``` | ||
save the file and exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
save the file and exit | |
Save the file and exit |
@nitish-samsung-jha sorry this took me so long to review! I left some requested changes and questions, I think these will just be minor edits I hope. Thank you for contributing this 🙏 |
@sfirke Thanks for review comments. I have incorporated the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two more tiny fixes (sorry if I was the one who put that period in the wrong place 😳 )
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
@sfirke , Thanks for review comments. I have applied suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thanks so much @nitish-samsung-jha ! |
…or (apache#25551) Co-authored-by: Sam Firke <[email protected]>
…or (apache#25551) Co-authored-by: Sam Firke <[email protected]>
…or (apache#25551) Co-authored-by: Sam Firke <[email protected]>
…or (apache#25551) Co-authored-by: Sam Firke <[email protected]>
Updated docs for handling "System limit for number of file watchers reached" error