fix: docker-compose non-dev #25055
Merged
fix: docker-compose non-dev #25055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
approved these changes
Aug 22, 2023
john-bodley
reviewed
Aug 22, 2023
|
|
||
| # database engine specific environment variables | ||
| # change the below if you prefer another database engine | ||
| DATABASE_PORT=5432 |
| EXAMPLES_HOST = os.getenv("EXAMPLES_HOST", "db") | ||
| EXAMPLES_PORT = os.getenv("EXAMPLES_PORT", "5432") | ||
| EXAMPLES_DB = os.getenv("EXAMPLES_DB", "examples") | ||
| DATABASE_DIALECT = os.getenv("DATABASE_DIALECT") |
There was a problem hiding this comment.
I think this is acceptable. The only other formulation I can think is having Python parse the .env-non-dev file to read the fallbacks from there. It seems like the file adheres to the configparser format.
There was a problem hiding this comment.
Spoke with @michael-s-molina offline who confirmed that the Docker variables are environment variables and thus my previous comment can be ignored.
9 tasks
john-bodley
added
the
review:checkpoint
michael-s-molina
added
the
v3.0
michael-s-molina
added a commit
that referenced
this pull request
Aug 23, 2023
(cherry picked from commit 7317d9c)
john-bodley
removed
the
review:checkpoint
9 tasks
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes
docker-compose -f docker-compose-non-dev.yml uperror reported here.Follow-up of #25003
TESTING INSTRUCTIONS
Make sure
docker-compose -f docker-compose-non-dev.yml upis working.ADDITIONAL INFORMATION