-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: timezone issue in Pandas 2 #24955
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24955 +/- ##
===========================================
- Coverage 69.03% 58.36% -10.67%
===========================================
Files 1905 1905
Lines 74136 74136
Branches 8212 8212
===========================================
- Hits 51181 43272 -7909
- Misses 20832 28741 +7909
Partials 2123 2123
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 293 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit aca006f)
🏷️ preset:2023.31 |
Thanks @betodealmeida and sorry for the trouble with my PR. Next time I'll try to test my PRs more and not just rely on unit / integration tests and my own datasets. I hope this was the last regression caused by #24768 🙏 |
SUMMARY
Pandas 2.0 doesn't like when we create a series of type
datetime64[ns]
from a timezone-aware datetime:This used to work fine in 1.5.3 (also tested in 1.3.4):
This PR fixes it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION