Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete Druid NoSQL REGEX operator #24415

Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

Whilst reading over this code I realized that the REGEX filter operator is unused—a byproduct of the Druid NoSQL connector which has been removed.

This PR removes the obsolete options from the UI controls to prevent erroneous backend errors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screenshot 2023-06-15 at 8 52 53 PM

Screenshot 2023-06-15 at 7 57 24 PM

AFTER

Screenshot 2023-06-15 at 8 52 26 PM

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley force-pushed the john-bodley--druid-no-sql-regex branch from f3e5bad to ab3e235 Compare June 16, 2023 04:06
@john-bodley john-bodley marked this pull request as ready for review June 16, 2023 04:06
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #24415 (a010793) into master (b68de27) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a010793 differs from pull request most recent head 499a197. Consider uploading reports for the commit 499a197 to get more accurate results

@@            Coverage Diff             @@
##           master   #24415      +/-   ##
==========================================
- Coverage   68.93%   68.93%   -0.01%     
==========================================
  Files        1904     1904              
  Lines       73879    73877       -2     
  Branches     8119     8119              
==========================================
- Hits        50928    50926       -2     
  Misses      20840    20840              
  Partials     2111     2111              
Flag Coverage Δ
hive 53.94% <ø> (-0.01%) ⬇️
javascript 55.65% <ø> (ø)
mysql 79.25% <ø> (-0.01%) ⬇️
postgres 79.34% <ø> (-0.01%) ⬇️
presto 53.86% <ø> (-0.01%) ⬇️
python 83.33% <ø> (-0.01%) ⬇️
sqlite 77.83% <ø> (-0.01%) ⬇️
unit 54.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/explore/constants.ts 100.00% <ø> (ø)
superset/utils/core.py 91.53% <ø> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit db65b74 into apache:master Jun 17, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants