-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dashboard ownership check #24249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24249 +/- ##
=======================================
Coverage 68.30% 68.30%
=======================================
Files 1957 1957
Lines 75596 75596
Branches 8222 8222
=======================================
Hits 51639 51639
Misses 21849 21849
Partials 2108 2108
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
(cherry picked from commit 7e70f19)
cc: @eschutho |
Co-authored-by: Beto Dealmeida <[email protected]>
(cherry picked from commit 7e70f19)
(cherry picked from commit 7e70f19)
(cherry picked from commit 7e70f19)
* fix: dashboard ownership check (apache#24249) * Change dashboard standalone mode to fix report screenshot error --------- Co-authored-by: Beto Dealmeida <[email protected]>
SUMMARY
Fix dashboard ownership check. There's currently a bug where non-admin users can't edit a dashboard (even a new one) because
username
was removed from the API response payload in #24056, making this check fail:superset/superset-frontend/src/dashboard/util/permissionUtils.ts
Line 45 in 674da1b
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
I'm adding the tests in a separate PR, so we can cherry-pick this quickly.
ADDITIONAL INFORMATION