-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native-filters): Fix encoding of non-temporal default values #23779
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23779 +/- ##
=======================================
Coverage 67.87% 67.87%
=======================================
Files 1925 1925
Lines 74389 74389
Branches 8108 8108
=======================================
Hits 50494 50494
Misses 21818 21818
Partials 2077 2077
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…che#23779) (cherry picked from commit 4b3e507)
…ues (apache#23779)" This reverts commit 4b3e507.
…che#23779) (cherry picked from commit 4b3e507)
SUMMARY
Whilst working on #23269 I misinterpreted the encoding of the dashboard level default values for the non-temporal filters, i.e., in the following
dashboards.json_metadata
,only filters which allow multiple selections (
baz
) are encoded as a list whereas non-multiple selections are encoded as a scalar (bar
), whereas I had initially thought they were all encoded as a list.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Tested locally.
ADDITIONAL INFORMATION