fix(dashboard): show_native_filters
leftover
#23389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#23228 removed
show_native_filters
from dashboards, but it can still be present in exports from older versions. When the key is present, the dashboard is imported correctly, but can't be updated because the schema ofjson_metadata
is now invalid.This PR addresses the problem by removing the field on dashboard import. Additionally, for those dashboards that have already been imported with the field, it relaxes the metadata schema to allow updates when
show_native_filters
is present, removing it before processing the metadata.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION