Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migration): Address issue in #23228 #23276

Merged
merged 2 commits into from
Mar 7, 2023
Merged

fix(migration): Address issue in #23228 #23276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79dfd59
fix(migration): Address issue in #23228
john-bodley Mar 4, 2023
2817216
Update 2023-02-28_14-46_c0a3ea245b61_remove_show_native_filters.py
john-bodley Mar 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions superset/migrations/versions/2023-02-28_14-46_c0a3ea245b61_remove_show_native_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,20 @@

import json

import sqlalchemy as sa
from alembic import op
from sqlalchemy.ext.declarative import declarative_base

from superset import db
from superset.models.dashboard import Dashboard

Base = declarative_base()


class Dashboard(Base):
__tablename__ = "dashboards"

id = sa.Column(sa.Integer, primary_key=True)
json_metadata = sa.Column(sa.Text)


def upgrade():
Expand All @@ -45,7 +55,6 @@ def upgrade():
if "show_native_filters" in json_metadata:
del json_metadata["show_native_filters"]
dashboard.json_metadata = json.dumps(json_metadata)
session.merge(dashboard)
except Exception: # pylint: disable=broad-except
pass

Expand Down