Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removes duplicated Bar Chart when GENERIC_CHART_AXES is enabled #22434

Closed
wants to merge 1 commit into from
Closed

fix: Removes duplicated Bar Chart when GENERIC_CHART_AXES is enabled #22434

wants to merge 1 commit into from

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Dec 15, 2022 •
edited
Loading

SUMMARY

Removes duplicated Bar Chart when GENERIC_CHART_AXES feature flag is enabled.

Follow-up of #22369

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-12-15 at 4 18 58 PM

Screen Shot 2022-12-15 at 4 19 18 PM

TESTING INSTRUCTIONS

  • Enable GENERIC_CHART_AXES feature flag
  • Search for "bar chart" in viz gallery
  • It should present "Bar Chart" and "Bar Chart (legacy)"

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina changed the title fix: Removes duplicated BarChart when GENERIC_CHART_AXES is enabled fix: Removes duplicated Bar chart when GENERIC_CHART_AXES is enabled Dec 15, 2022
@michael-s-molina michael-s-molina changed the title fix: Removes duplicated Bar chart when GENERIC_CHART_AXES is enabled fix: Removes duplicated Bar Chart when GENERIC_CHART_AXES is enabled Dec 15, 2022
@michael-s-molina
Copy link
Member Author

Closed as it duplicates #22430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas Awaiting requested review from rusackas

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michael-s-molina