fix: make database connection modal ace fields uncontrolled

[eschutho]

SUMMARY

I recently refactored the extraJson field #21523 so that we didn't have to do any data munging on database connection save, but rather can use the state that is in the local component and just push it to the api. The tricky situation here is that ace expects a string value, but we are pasting stringified objects into the field, so when we have to parse it later to add to the extra field, it also parses the ace contents. This pr makes the ace editor and input fields in the extra options component uncontrolled so that we don't have to parse the state back into a string again.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

You should be able to edit the engine parameters field in the "Other" section of the database connection form on creation and edit for all databases. There should be no extra characters added to the editor as you type.

ADDITIONAL INFORMATION

• Has associated issue: fixes 'str' object does not support item assignment, while Databrciks database connection #22267
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[lyndsiWilliams]

/testenv up

[github-actions]

@lyndsiWilliams Container image not yet published for this PR. Please try again when build is complete.

[github-actions]

@lyndsiWilliams Ephemeral environment creation failed. Please check the Actions logs for details.

[codecov]

Codecov Report

Merging #22350 (ce815d0) into master (605cfa0) will increase coverage by 0.01%.
The diff coverage is 36.36%.

❗ Current head ce815d0 differs from pull request most recent head f3cb414. Consider uploading reports for the commit f3cb414 to get more accurate results

@@            Coverage Diff             @@
##           master   #22350      +/-   ##
==========================================
+ Coverage   66.86%   66.88%   +0.01%     
==========================================
  Files        1847     1847              
  Lines       70574    70580       +6     
  Branches     7748     7749       +1     
==========================================
+ Hits        47190    47204      +14     
+ Misses      21383    21360      -23     
- Partials     2001     2016      +15     

Flag	Coverage Δ
javascript	53.86% <36.36%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx	43.76% <33.33%> (+2.76%)	⬆️
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx	70.37% <37.50%> (-4.63%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[lyndsiWilliams]

/testenv up

[github-actions]

@lyndsiWilliams Ephemeral environment spinning up at http://34.221.105.24:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[eschutho]

/testenv up

[github-actions]

@eschutho Ephemeral environment spinning up at http://35.89.15.116:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[lyndsiWilliams]

Tested locally with a gsheet, every seems to be working properly! Nice fix!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.