-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(init): Initialize _jwt_cookie_name in AsyncQueryManager __init__ #22314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22314 +/- ##
==========================================
- Coverage 65.59% 65.43% -0.17%
==========================================
Files 1847 1847
Lines 70333 70333
Branches 7702 7702
==========================================
- Hits 46138 46020 -118
- Misses 22197 22315 +118
Partials 1998 1998
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfectly straightforward to me, but I'll let this bake a moment, in case anyone sees some random risk with this.
IIRC this happens when you flip the flag but don't restart your Celery process. I wonder if there's other problems that arise if Celery isn't restarted after enabling GAC.. |
@villebro I'm not sure. We deploy the whole installation including celery workers as a service in Kubernetes and redeploy it all together. Maybe the problem is with the order of pods restarting. |
The order shouldn't matter, as the celery workers use the same config as the web workers (if you're using the default helm chart). |
SUMMARY
We face an issue. After setting
GLOBAL_ASYNC_QUERIES
toTrue
and switching back again toFalse
we gain errors'AsyncQueryManager' object has no attribute '_jwt_cookie_name'
.Stacktrace of this error:
Initializing this field inside
__init__
fixes this issue.