Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Horizontal FilterBar e2e tests #22305

Merged
merged 8 commits into from
Dec 6, 2022
Merged

chore: Add Horizontal FilterBar e2e tests #22305

merged 8 commits into from
Dec 6, 2022

Conversation

geido
Copy link
Member

@geido geido commented Dec 1, 2022

SUMMARY

Adds Horizontal FilterBar e2e tests

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #22305 (62ee069) into master (aba3b81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22305   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1847     1847           
  Lines       70497    70497           
  Branches     7722     7722           
=======================================
  Hits        47131    47131           
  Misses      21365    21365           
  Partials     2001     2001           
Flag Coverage Δ
hive 52.53% <ø> (ø)
javascript 53.77% <ø> (ø)
mysql 77.96% <ø> (ø)
postgres 78.02% <ø> (ø)
presto 52.42% <ø> (ø)
python 81.24% <ø> (ø)
sqlite 76.49% <ø> (ø)
unit 50.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/components/DropdownContainer/index.tsx 72.83% <ø> (ø)
superset-frontend/src/components/Loading/index.tsx 100.00% <ø> (ø)
...ers/FilterBar/FilterBarOrientationSelect/index.tsx 92.85% <ø> (ø)
.../components/nativeFilters/FilterBar/Horizontal.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido geido marked this pull request as ready for review December 2, 2022 18:04
Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit e1ffdb9 into master Dec 6, 2022
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Dec 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/hfb-e2e-tests branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.49 size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants