Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native-filters): Misc spacing fixes for horizontal and horizontal overflow filter bar items #22288

Merged
merged 3 commits into from
Dec 1, 2022
Merged

fix(native-filters): Misc spacing fixes for horizontal and horizontal overflow filter bar items #22288

merged 3 commits into from
Dec 1, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Dec 1, 2022

SUMMARY

This PR tightens up some styles:

  • There is no longer double divider lines when a divider is the first item in the horizontal filter bar.
  • The initial divider line and the other divider lines in the horizontal filter bar are now the same height.
  • Text spacing in the overflow menu is now more uniform.
  • The "Filters out of scope" item in horizontal overflow no longer has unbalanced top/bottom margin when it's the only item.
  • "Filters out of scope" in horizontal overflow contents are now more consistently spaced.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-11-30 at 4 24 02 PM
Screen Shot 2022-11-30 at 4 24 34 PM
Screen Shot 2022-11-30 at 4 24 59 PM
Screen Shot 2022-11-30 at 4 25 03 PM

After:
Screen Shot 2022-11-30 at 4 22 34 PM
Screen Shot 2022-11-30 at 4 22 45 PM
Screen Shot 2022-11-30 at 4 23 08 PM
Screen Shot 2022-11-30 at 4 23 13 PM

TESTING INSTRUCTIONS

  • Check that the above spacing/styling issues are resolved.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: HORIZONTAL_FILTER_BAR
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codyml codyml force-pushed the fix/filter-spacing branch from 92002cc to 64b49d2 Compare December 1, 2022 00:27
@codecov
Copy link

codecov bot commented Dec 1, 2022 •
edited
Loading

Codecov Report

Merging #22288 (1f79f3b) into master (3ffe782) will not change coverage.
The diff coverage is 33.33%.

❗ Current head 1f79f3b differs from pull request most recent head 64b49d2. Consider uploading reports for the commit 64b49d2 to get more accurate results

@@           Coverage Diff           @@
##           master   #22288   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files        1846     1846           
  Lines       70286    70286           
  Branches     7683     7684    +1     
=======================================
  Hits        46948    46948           
  Misses      21346    21346           
  Partials     1992     1992
Flag Coverage Δ
javascript 53.79% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Filters/FilterBar/FilterControls/FilterControl.tsx 29.03% <ø> (ø)
...Filters/FilterBar/FilterControls/FilterDivider.tsx 84.00% <ø> (ø)
...Filters/FilterBar/FiltersDropdownContent/index.tsx 25.00% <ø> (ø)
...s/FilterBar/FiltersOutOfScopeCollapsible/index.tsx 20.00% <0.00%> (ø)
...ilters/FilterBar/FilterControls/FilterControls.tsx 70.21% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kgabryje
kgabryje reviewed Dec 1, 2022
View reviewed changes
...t-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterDivider.tsx
@@ -124,7 +130,8 @@ const HorizontalOverflowDivider = ({
display: block;
font-size: ${theme.typography.sizes.s}px;
color: ${theme.colors.grayscale.base};
margin: 0;
margin: ${theme.gridUnit * 2.5}px 0 0 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should use full grid units. Can we change 2.5 to 2 or 3 (whichever looks better)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #22307!

@kgabryje
Copy link
Member

kgabryje commented Dec 1, 2022

/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

@kgabryje Ephemeral environment spinning up at http://18.237.102.21:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

kgabryje
kgabryje approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small non-blocking nit that we can address later, otherwise LGTM!

@kgabryje kgabryje merged commit 04e0bb9 into apache:master Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Ephemeral environment shutdown and build artifacts deleted.

@codyml codyml mentioned this pull request Dec 1, 2022
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codyml @kgabryje @mistercrunch