-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a new database driver for Amazon DynamoDB #22077
Conversation
…erset into dynamodb_engine_spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new database driver for AWS DynamoDB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #22077 +/- ##
==========================================
- Coverage 67.12% 65.66% -1.47%
==========================================
Files 1818 1819 +1
Lines 69639 69656 +17
Branches 7496 7496
==========================================
- Hits 46747 45738 -1009
- Misses 20954 21980 +1026
Partials 1938 1938
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@villebro, my bad. I forgot to update the docs with this PR. So created the new PR to do that. Thanks for your caring. :D |
SUMMARY
There is no database driver for Amazon DynamoDB so far. I developed a Python DB API 2.0 (PEP 249) client for Amazon DynamoDB and did some work to be compatible with Superset. My Project is here. The latest version is 0.4.2 which have already supported Superset connector.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Add the unit test for db_engine_spec of pydynamodb.
For the setup in the Superset, please refer to the doc in my project.
https://github.com/passren/PyDynamoDB/wiki/5.-Superset
ADDITIONAL INFORMATION