-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sqllab): Change icon color for running sql #22050
chore(sqllab): Change icon color for running sql #22050
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22050 +/- ##
=======================================
Coverage 66.97% 66.97%
=======================================
Files 1832 1832
Lines 69905 69909 +4
Branches 7570 7571 +1
=======================================
+ Hits 46820 46823 +3
Misses 21127 21127
- Partials 1958 1959 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Woot! I never realized that the icon changed. @justinpark rather than flashing I was wondering whether a different color would be more intuitive, i.e.,
Note people are red/green colorblind so maybe having a check-mark/x-mark inside the circle would help to distinguish between (3) and (4). * I think blue is likely better than orange as orange normally implies warning. |
@john-bodley that's good idea. I updated the icons accordingly. |
This is awesome @justinpark! |
9ac566a
to
b8be2b7
Compare
Nice |
SUMMARY
There's an open issue that is hard to distinguish icons between running and successful query state in sqllab.
This commit adds the animated dimming translation for running statue to be distinguishing the running state easily.This commit updates the icon color for running state to be distinguishing the running and finish states. It also adds the icons for success and fail status to help red/green colorblind to distinguish the color status.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Go to sqllab
Run a query
ADDITIONAL INFORMATION