-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add metadata namespace
#22020
feat(helm): add metadata namespace
#22020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls bump chart version
Added and thanks! |
@Yann-J - any idea why CI is failing here? |
Yeah, the new @waynewenswag I cannot push to your branch to fix it, but all you need is to run all pre-commit checks with You may need to install/update them or their dependencies first of course:
|
@Yann-J @craig-rueda Fixed |
Awesome, thanks @Yann-J ! |
SUMMARY
Add
metadata.namespace
to deploy with kustomizeBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION