-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade [email protected] #22007
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22007 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1815 1815
Lines 69575 69575
Branches 7486 7486
=======================================
Hits 46665 46665
Misses 20974 20974
Partials 1936 1936
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
Outdated
Show resolved
Hide resolved
@geido Adding the code below in
|
Nice catch @michael-s-molina. I don't know how I didn't see this before! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - clicked around home, Explore Dashboard view/edit, datasets, SQL Lab and everything looked fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, run automation and did not see any blocker
SUMMARY
Upgrades Antd to version 4.10.3, in order to use property
maxTagCount="responsive"
in the Select component enabling dropdowns to display tags responsively.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
N.A.
ADDITIONAL INFORMATION