Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(helm): Helm-docs + fix Helm chart release #21963

Merged
merged 13 commits into from
Oct 29, 2022
Merged

build(helm): Helm-docs + fix Helm chart release #21963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
26b921e
Adds helm-docs automated README generation in CI and pre-commit
Yann-J Oct 27, 2022
c34de58
Merge branch 'master' into helm-docs
Yann-J Oct 28, 2022
774f6ae
Merge branch 'master' into helm-docs
Yann-J Oct 28, 2022
1416d57
Add helm dependencies in release action
Yann-J Oct 28, 2022
8b58d9f
Bump chart version
Yann-J Oct 28, 2022
fa9322e
Install helm-docs to run pre-commit
Yann-J Oct 28, 2022
a382204
Set up brew
Yann-J Oct 28, 2022
a907f2f
Activate brew manually
Yann-J Oct 28, 2022
34ca22e
Skip helm-docs in pre-commit
Yann-J Oct 28, 2022
b36059b
Filter helm-docs folder
Yann-J Oct 29, 2022
bba59f6
Setup brew
Yann-J Oct 29, 2022
3bef93d
Fix brew install
Yann-J Oct 29, 2022
de9f2bf
Remove redundant helm-docs workflow
Yann-J Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/superset-helm-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: Release Charts
on:
push:
branches:
- 'master'
- "master"
paths:
- 'helm/**'
- "helm/**"

jobs:
release:
Expand All @@ -28,6 +28,9 @@ jobs:
with:
version: v3.5.4

- name: Add bitnami repo dependency
run: helm repo add bitnami https://charts.bitnami.com/bitnami

- name: Run chart-releaser
uses: ./.github/actions/chart-releaser-action
with:
Expand Down
19 changes: 14 additions & 5 deletions .github/workflows/superset-python-misc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
cache-dependency-path: 'requirements/testing.txt'
cache: "pip"
cache-dependency-path: "requirements/testing.txt"
- name: Install dependencies
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
cache: "pip"
cache-dependency-path: |
requirements/base.txt
requirements/integration.txt
Expand All @@ -78,6 +78,15 @@ jobs:
pip install wheel
pip install -r requirements/base.txt
pip install -r requirements/integration.txt
# Add brew to the path - see https://github.com/actions/runner-images/issues/6283
- name: Enable brew and helm-docs
run: |
echo "/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin" >> $GITHUB_PATH
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
echo "HOMEBREW_PREFIX=$HOMEBREW_PREFIX" >>"${GITHUB_ENV}"
echo "HOMEBREW_CELLAR=$HOMEBREW_CELLAR" >>"${GITHUB_ENV}"
echo "HOMEBREW_REPOSITORY=$HOMEBREW_REPOSITORY" >>"${GITHUB_ENV}"
brew install norwoodj/tap/helm-docs
- name: pre-commit
run: pre-commit run --all-files

Expand All @@ -97,8 +106,8 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
cache-dependency-path: 'requirements/base.txt'
cache: "pip"
cache-dependency-path: "requirements/base.txt"
- name: Install dependencies
uses: ./.github/actions/cached-dependencies
with:
Expand Down
9 changes: 7 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,16 @@ repos:
rev: v2.4.1 # Use the sha or tag you want to point at
hooks:
- id: prettier
args: ['--ignore-path=./superset-frontend/.prettierignore']
files: 'superset-frontend'
args: ["--ignore-path=./superset-frontend/.prettierignore"]
files: "superset-frontend"
# blacklist unsafe functions like make_url (see #19526)
- repo: https://github.com/skorokithakis/blacklist-pre-commit-hook
rev: e2f070289d8eddcaec0b580d3bde29437e7c8221
hooks:
- id: blacklist
args: ["--blacklisted-names=make_url", "--ignore=tests/"]
- repo: https://github.com/norwoodj/helm-docs
rev: v1.11.0
hooks:
- id: helm-docs
files: helm
2 changes: 1 addition & 1 deletion helm/superset/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ maintainers:
- name: craig-rueda
email: [email protected]
url: https://github.com/craig-rueda
version: 0.7.5
version: 0.7.6
dependencies:
- name: postgresql
version: 11.1.22
Expand Down
2 changes: 1 addition & 1 deletion helm/superset/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

# superset

![Version: 0.7.5](https://img.shields.io/badge/Version-0.7.5-informational?style=flat-square)
![Version: 0.7.6](https://img.shields.io/badge/Version-0.7.6-informational?style=flat-square)

Apache Superset is a modern, enterprise-ready business intelligence web application

Expand Down