-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Selectable dropdown triggered by icon component #21955
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21955 +/- ##
==========================================
- Coverage 66.98% 66.82% -0.17%
==========================================
Files 1808 1809 +1
Lines 69289 69304 +15
Branches 7407 7410 +3
==========================================
- Hits 46412 46311 -101
- Misses 20968 21083 +115
- Partials 1909 1910 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -86,6 +91,24 @@ const Header: FC<HeaderProps> = ({ toggleFiltersBar }) => { | |||
<Wrapper> | |||
<TitleArea> | |||
<span>{t('Filters')}</span> | |||
<DropdownSelectableIcon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put it behind a feature flag please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And restrict access to users with dashboard edit permission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put adding the gear icon to filter bar behind feature flag HORIZONTAL_FILTER_BAR
?
…/horizontal-filter-bar-gearmenu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
SUMMARY
This PR implements a selectable dropdown menu that can be opened through an icon. This is useful for the implementation of the horizontal filter bar and has been included in the header of the filter bar for that reason.
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION