-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate ant d table component into DatasetPanel #21948
feat: Integrate ant d table component into DatasetPanel #21948
Conversation
Very rough starting point for new table component
…sign system overview mdx, and Table overview mdx
…g drop code into separate class
…tation, fixes re-orderable drag drop columns issue
… columns for the selected database table
…oves responsive behavior for DatasetPanel
Codecov Report
@@ Coverage Diff @@
## master #21948 +/- ##
==========================================
- Coverage 67.09% 65.61% -1.48%
==========================================
Files 1827 1829 +2
Lines 69866 69840 -26
Branches 7548 7570 +22
==========================================
- Hits 46875 45826 -1049
- Misses 21035 22056 +1021
- Partials 1956 1958 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/packages/superset-ui-core/src/style/index.tsx
Outdated
Show resolved
Hide resolved
/testenv up |
@pkdotson Ephemeral environment spinning up at http://54.213.38.241:8080. Credentials are |
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lyndsi Kay Williams <[email protected]>
Co-authored-by: Lyndsi Kay Williams <[email protected]>
…ll/ActionCell.overview.mdx Co-authored-by: Michael S. Molina <[email protected]>
…ll/ActionCell.overview.mdx Co-authored-by: Michael S. Molina <[email protected]>
…td' into ericbriscoe/sc-56078/create-dataset-add-antd-table-component-into
Co-authored-by: Michael S. Molina <[email protected]>
…t was called from
…based on PR question
…td' into ericbriscoe/sc-56078/create-dataset-add-antd-table-component-into
…td-table-component-into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question, it looks good but going to start an ephemeral for final testing. Specifically wanna check with different window sizes.
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx
Show resolved
Hide resolved
/testenv up |
@AAfghahi Ephemeral environment spinning up at http://35.89.122.245:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! I found a couple of theming/TS things and also some act errors.
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/types.ts
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/types.ts
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/types.ts
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lyndsi Kay Williams <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work on this!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Integrates a re-usable antd based Table into the DatasetPanel for new Dataset creation workflow
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
DatasetPanel.mov
TESTING INSTRUCTIONS
You can also interact with the DatasetPanel in isolation via storybook:
npm run storybook
ADDITIONAL INFORMATION