-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Preserve unknown URL params #21785
fix: Preserve unknown URL params #21785
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21785 +/- ##
==========================================
- Coverage 66.86% 65.36% -1.50%
==========================================
Files 1803 1803
Lines 68996 68995 -1
Branches 7349 7349
==========================================
- Hits 46132 45102 -1030
- Misses 20971 22000 +1029
Partials 1893 1893
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've verified that both the URL parameters persist and the short links work, however it seems that the URL parameters are not being leveraged by the SQL template, though that's likely a different issue. My hunch is they're not being added to the form-data via the url_params
key.
(cherry picked from commit 11d7d6e)
SUMMARY
Fixes a bug where unknown URL params were not being preserved in the URL. This fix also resolves a bug where old short URLs in the form of
/r/<id>
were not opening because it depended on ther
query parameter. It may also fix other issues that depend on unknown parameters such as Jinja templating.Fixes #20825
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-10-12.at.11.22.14.AM.mov
TESTING INSTRUCTIONS
1 - Check that unknown parameters are preserved in the URL
2 - Check that old links in the
/r/<id>
form are supportedADDITIONAL INFORMATION