-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cross-referenced Dashboards in Chart list (Column + Filter) #21760
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21760 +/- ##
==========================================
- Coverage 66.86% 66.85% -0.01%
==========================================
Files 1803 1805 +2
Lines 68996 69053 +57
Branches 7349 7368 +19
==========================================
+ Hits 46132 46165 +33
- Misses 20971 20991 +20
- Partials 1893 1897 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/src/components/ListView/CrossLinksTooltip.tsx
Outdated
Show resolved
Hide resolved
Left some minor comments. Tagging @kasiazjc for truncation behaviour review 🙂 |
/testenv up FEATURE_CROSS_REFERENCES=true |
@kgabryje Ephemeral environment spinning up at http://34.216.180.224:8080. Credentials are |
Co-authored-by: Kamil Gabryjelski <[email protected]>
…apache/superset into feat/d2d-charts-crud-filter-col
/testenv up FEATURE_CROSS_REFERENCES=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @geido! I left some first-pass comments.
…/d2d-charts-crud-filter-col
@geido Ephemeral environment spinning up at http://34.214.27.57:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in my local. work as expected.
Can you make the Screen.Recording.2022-10-12.at.7.48.04.AM.mov |
…/d2d-charts-crud-filter-col
/testenv up FEATURE_CROSS_REFERENCES=true |
@geido Ephemeral environment spinning up at http://54.188.233.155:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing all the comments!
Ephemeral environment shutdown and build artifacts deleted. |
@geido I believe there's an issue with this feature when backend querying is required, i.e., the following request,
throws the following FAB error:
|
Thanks @john-bodley I will have a look |
SUMMARY
This PR adds the ability to filter the Charts by the cross-referenced Dashboards. It also shows the referenced Dashboards in a new column.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
DEV.Superset.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION