fix(sqllab): resultset disappeared on switching tabs #21741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since the rendering refactoring by #20877, the number of redundant rendering reduced.
The FilterableTable re-rendering reduced related to the unnecessary property update but it wasn't reloaded when height is updated. It's mainly caused by functional component refactoring at #21136 which uses
useRef
to capture the height so it won't refreshed with the updatedheight
prop properly.https://github.com/EugeneTorap/superset/blob/66b704c13ae5b3840109c584989b1248cafb86e1/superset-frontend/src/components/FilterableTable/index.tsx#L335-L336
This occurs the empty result-set problem due to react-virtualized rendering issue with
NaN
height value.This commit fixes the rendering issue with the updated height value.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
filterableTable--before.mov
filterableTable--after.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
cc: @EugeneTorap